skills: add release_updates automation for release docs updates#171
skills: add release_updates automation for release docs updates#171dannyneira wants to merge 5 commits into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a new release_updates skill with scripts to automate weekly changelog, license, telemetry, and Warp artifact preparation for docs maintenance. I found two correctness issues in the generated workflow: the documented default dry run cannot complete without real artifact sources, and newly-created changelog year files can be populated with entries from every historical year.
Concerns
- The documented
--dry-runall-task command fails once downstream tasks try to read artifact-derived license/telemetry inputs that the dry-run artifact step never creates. - The changelog updater does not filter entries to the requested output year when creating a new year file, so a new annual changelog can import older years' releases.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Co-Authored-By: Oz <oz-agent@warp.dev>
There was a problem hiding this comment.
Overview
This PR adds a new release_updates skill and standalone Python scripts for weekly Warp docs maintenance. I reviewed the attached diff and found correctness issues in the changelog year handling and on-call reviewer resolution, plus one PR-artifact hygiene concern.
Concerns
- Creating a new yearly changelog file can include historical releases from other years because entries are not filtered to the requested year.
- On-call reviewer fallback matching only reads the first 100 GitHub org members, which can fail for valid on-call users in larger orgs.
- The telemetry generator defaults an intermediate JSON artifact to the repo root, which can be swept into automated PR commits.
Verdict
Found: 0 critical, 2 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a new release_updates skill and standalone automation scripts for weekly changelog, license, telemetry, Warp artifact, and PR maintenance. The implementation covers the intended workflow, but I found issues that should be fixed before merge around public exposure of internal reviewer mappings, unsafe rendering of release metadata into MDX, and incomplete changelog year-rollover navigation updates.
Concerns
- The on-call reviewer resolver commits specific internal email-to-GitHub mappings into the public docs repo.
- The changelog renderer interpolates network-sourced
image_urldirectly into an HTML attribute, which can generate unsafe MDX if the release metadata is malformed or compromised. - New changelog year files update only
src/content/docs/changelog/index.mdx;src/sidebar.tsremains hard-coded and will omit the new year from navigation.
Security
- Avoid committing internal email mappings in repository code; keep overrides in private configuration or derive them from authenticated GitHub/Grafana APIs.
- Escape or validate release metadata before rendering it into MDX/HTML.
Verdict
Found: 0 critical, 3 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
Summary
Adds a new
release_updatesskill in the docs repo with standalone scripts for weekly release docs maintenance, including Linux/Oz-compatible Warp artifact preparation.Changes
.agents/skills/release_updates/SKILL.mdwith usage for:.agents/skills/release_updates/scripts/:update_warp_app.pyupdate_changelog.pyupdate_licenses.pyupdate_telemetry.pyrun_release_updates.pycommon.pyrun_release_updates.py:warp_app_updatechangeloglicensestelemetryValidation
python3 -m py_compile .agents/skills/release_updates/scripts/common.py .agents/skills/release_updates/scripts/update_warp_app.py .agents/skills/release_updates/scripts/update_changelog.py .agents/skills/release_updates/scripts/update_licenses.py .agents/skills/release_updates/scripts/update_telemetry.py .agents/skills/release_updates/scripts/run_release_updates.pypython3 .agents/skills/release_updates/scripts/run_release_updates.py --tasks changelog --dry-run --docs-repo /Users/danny/dx/src/warp_docspython3 .agents/skills/release_updates/scripts/run_release_updates.py --tasks warp_app_update --dry-runpython3 .agents/skills/release_updates/scripts/run_release_updates.py --tasks telemetry --telemetry-json-file /Users/danny/dx/src/warp_docs/telemetry.json --dry-run --docs-repo /Users/danny/dx/src/warp_docsCo-Authored-By: Oz oz-agent@warp.dev